Add CnyExternalAccountCreateInfo + register in CreateInfo OneOf by mohamedwane · Pull Request #552 · lightsparkdev/grid-api

mohamedwane · 2026-06-05T01:46:06Z

Summary

Adds the missing CnyExternalAccountCreateInfo.yaml (hand-authored, mirrors the existing BdtExternalAccountCreateInfo.yaml template) and registers it in ExternalAccountCreateInfoOneOf.yaml.
The auto-sync workflow's create_external_accounts.py only generates the read-side {Currency}ExternalAccountInfo.yaml; the create-side {Currency}ExternalAccountCreateInfo.yaml is hand-authored per corridor and was missed when CNY landed via chore: Sync account schemas #551. Without the create variant in the OneOf, the discriminator can't dispatch accountType: CNY_ACCOUNT on POST /customers/external-accounts and the request fails with "did not match any expected shape".

Test plan

npm run build:openapi produces a bundle that contains CnyExternalAccountCreateInfo (line 15259 in the regenerated openapi.yaml).
After merge, regen the downstream sparkcore mirror via update_schema.sh and confirm grid_api/models/cny_external_account_create_info.py exists.
Once mirror regen lands in sparkcore, EGP-style CNY create payload accepts.

vercel · 2026-06-05T01:46:11Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
grid-flow-builder	Ignored	Preview	Jun 5, 2026 2:27am

github-actions · 2026-06-05T01:46:36Z

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

chore(internal): regenerate SDK with no functional changes

csharp

feat(api): add cny account support to agents/customers/platform external accounts

go

feat(api): add CNY account support to customer/platform external account creation

kotlin

feat(api): add CNY account support to external accounts

openapi

feat(api): add CNY account support to external accounts

php

feat(api): add CNY account type to external accounts

python

feat(api): add CNY account support to external_account parameters

ruby

feat(api): add CNY account type to external accounts

typescript

feat(api): add CNY_ACCOUNT support to external accounts

✅ grid-typescript studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → build ✅ → lint ✅ → test ✅
npm install https://pkg.stainless.com/s/grid-typescript/98235f5f29738efd5cdea95bd09e17640e0aa680/dist.tar.gz

✅ grid-openapi studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅

✅ grid-ruby studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → build ✅ → lint ✅ → test ✅

⚠️

grid-go studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅ → build ✅ → lint ❗ → test ❗
go get github.com/stainless-sdks/grid-go@245372ac26ce80d707978809c2327c2a72f85b1d

✅ grid-kotlin studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → build ✅ → lint ✅ → test ✅

⚠️

grid-python studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅ → build ✅ → lint ❗ → test ❗
pip install https://pkg.stainless.com/s/grid-python/7fdff690dd3dd545a85960bb31fbdc4f1fcdbe17/grid-0.0.1-py3-none-any.whl

⚠️

grid-csharp studio · code

Your SDK build had a failure in the build CI job, which is a regression from the base state.
generate ⚠️ → build ❗ → lint ✅ → test ❗

✅ grid-php studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → lint ✅ → test ✅

⚠️

grid-cli studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ⚠️ → build ⏭️ → lint ⏭️ → test ❗

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-06-05 16:51:13 UTC

greptile-apps · 2026-06-05T01:48:06Z

Greptile Summary

This PR adds the missing CnyExternalAccountCreateInfo.yaml create-side schema and registers it in ExternalAccountCreateInfoOneOf.yaml, fixing POST /customers/external-accounts requests with accountType: CNY_ACCOUNT that previously failed discriminator dispatch.

New schema (CnyExternalAccountCreateInfo.yaml): correctly mirrors the BdtExternalAccountCreateInfo.yaml template, composing BaseExternalAccountInfo, CnyAccountInfoBase, and a beneficiary oneOf with CnyBeneficiary/BusinessBeneficiary — all referenced schemas exist and resolve.
OneOf registration (ExternalAccountCreateInfoOneOf.yaml): CnyExternalAccountCreateInfo added to both the oneOf array and the discriminator.mapping block (the prior review's missing-mapping issue is resolved in this revision).
Bundled files (openapi.yaml, mintlify/openapi.yaml): regenerated to reflect the new schema.

Confidence Score: 5/5

Safe to merge — adds a well-scoped, missing schema file and its OneOf registration with no changes to existing entries.

The change is additive only: a new YAML file and two new lines in the OneOf registration. All $ref targets exist and resolve. The discriminator mapping entry is present and alphabetically ordered. No existing schemas or endpoints are modified.

No files require special attention.

Important Files Changed

Filename	Overview
openapi/components/schemas/external_accounts/CnyExternalAccountCreateInfo.yaml	New CNY create-side schema, correctly mirrors BdtExternalAccountCreateInfo.yaml with CNY-specific refs; all referenced schemas exist and resolve
openapi/components/schemas/external_accounts/ExternalAccountCreateInfoOneOf.yaml	Adds CnyExternalAccountCreateInfo to both the oneOf array and the discriminator.mapping block; CNY_ACCOUNT entry correctly placed alphabetically
openapi.yaml	Regenerated bundle reflecting the new CnyExternalAccountCreateInfo schema and OneOf registration
mintlify/openapi.yaml	Mintlify bundle regenerated to include CnyExternalAccountCreateInfo for docs

Sequence Diagram

sequenceDiagram
    participant Client
    participant API as POST /customers/external-accounts
    participant Discriminator as ExternalAccountCreateInfoOneOf
    participant Schema as CnyExternalAccountCreateInfo

    Client->>API: "{ accountType: "CNY_ACCOUNT", ... }"
    API->>Discriminator: resolve oneOf via discriminator
    Discriminator->>Schema: "mapping["CNY_ACCOUNT"] -> CnyExternalAccountCreateInfo.yaml"
    Schema->>Schema: "allOf [BaseExternalAccountInfo, CnyAccountInfoBase, {beneficiary}]"
    Schema-->>API: validated
    API-->>Client: 200 OK

_{Reviews (2): Last reviewed commit: "Add CnyExternalAccountCreateInfo + regis..." | Re-trigger Greptile}

The auto-sync workflow's create_external_accounts.py only generates the read-side `{Currency}ExternalAccountInfo.yaml`; the create-side `{Currency}ExternalAccountCreateInfo.yaml` is hand-authored per corridor and was missed when CNY landed via #551. Without the Create variant in `ExternalAccountCreateInfoOneOf`, the discriminator can't dispatch `accountType: CNY_ACCOUNT` on POST /customers/external- accounts and the request fails with "did not match any expected shape". This adds the missing schema (mirroring the existing BdtExternalAccountCreateInfo template) and inserts the $ref in the CreateInfoOneOf alphabetically between Cad and Cop.

mohamedwane · 2026-06-05T02:27:12Z

Good catch — fixed in 4451e8b. Added CNY_ACCOUNT: ./CnyExternalAccountCreateInfo.yaml to the discriminator.mapping block (between CAD_ACCOUNT and COP_ACCOUNT) and re-ran npm run build:openapi. The bundled openapi.yaml now carries CNY_ACCOUNT: '#/components/schemas/CnyExternalAccountCreateInfo' in the mapping. Also verified the read-side ExternalAccountInfoOneOf.yaml already had the matching CNY_ACCOUNT entry (auto-synced via #551), so this PR closes the gap on the create side.

## Summary - Add `CNY_ACCOUNT` to Grid Visualizer data files (`account-types.ts`, `currencies.ts`) - Move China from "Coming Soon" to supported countries in `country-support.mdx` - Update Asia-Pacific region count from 9 to 10 countries Syncs documentation and visualizer with CNY_ACCOUNT addition in #552. ## Test plan - [ ] Grid Visualizer renders CNY as a fiat destination option - [ ] Country support table shows China with `Bank Transfer` rail - [ ] Regional summary shows 10 countries for Asia-Pacific 🤖 Generated with [Claude Code](https://claude.com/claude-code)

mohamedwane force-pushed the mohamed/add-cny-external-account-create-info branch from 519bcee to 4451e8b Compare June 5, 2026 02:27

mohamedwane enabled auto-merge (squash) June 5, 2026 02:37

JasonCWang approved these changes Jun 5, 2026

View reviewed changes

mohamedwane merged commit 28bd8de into main Jun 5, 2026
9 checks passed

mohamedwane deleted the mohamed/add-cny-external-account-create-info branch June 5, 2026 16:44

claude Bot mentioned this pull request Jun 6, 2026

docs: sync CNY_ACCOUNT support with OpenAPI schema #555

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CnyExternalAccountCreateInfo + register in CreateInfo OneOf#552

Add CnyExternalAccountCreateInfo + register in CreateInfo OneOf#552
mohamedwane merged 1 commit into
mainfrom
mohamed/add-cny-external-account-create-info

mohamedwane commented Jun 5, 2026

Uh oh!

vercel Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jun 5, 2026 •

edited

Loading

Important Files Changed

Sequence Diagram

Uh oh!

mohamedwane commented Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mohamedwane commented Jun 5, 2026

Summary

Test plan

Uh oh!

vercel Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✱ Stainless preview builds for grid

Uh oh!

greptile-apps Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

mohamedwane commented Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Jun 5, 2026 •

edited

Loading

github-actions Bot commented Jun 5, 2026 •

edited

Loading

greptile-apps Bot commented Jun 5, 2026 •

edited

Loading